Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
doc:migration_guide [2016/03/04 13:49] gkazhoyadoc:migration_guide [2016/03/04 14:31] (current) – old revision restored (2016/02/09 19:12) gkazhoya
Line 21: Line 21:
 == Step 3: designator properties as keywords == == Step 3: designator properties as keywords ==
  
-Search for all ''make-designator'', ''with-designators'' and ''(desig-prop ?'' calls in all your Lisp files and change the designator properties there from simple symbols to keywords, e.g. '' 'on'' should become '':on''. Also, search for all ''desig-props'' in all your Lisp files and get rid of them, e.g.+Search for all ''make-designator'' and ''with-designators'' and change the type of the designator from simple symbol to a keyword, e.g.  
 +<code lisp> 
 +(make-designator 'location '((on table))) 
 +</code> 
 +should turn into 
 +<code lisp> 
 +(make-designator :location '((on table))) 
 +</code> 
 + 
 +Next search for all ''make-designator'', ''with-designators'' and ''(desig-prop ?'' calls in all your Lisp files and change the designator properties there from simple symbols to keywords, e.g. '' 'on'' should become '':on''. Also, search for all ''desig-props'' in all your Lisp files and get rid of them, e.g.
 <code lisp> <code lisp>
 (desig-prop ?designator (desig-props:to desig-props:see)) (desig-prop ?designator (desig-props:to desig-props:see))
Line 30: Line 39:
 </code> </code>
  
-Also, you can search for ''def-desig-package'' in all your ''package.lisp'' files and get rid of ''def-desig-package'' and ''designator-properties'' there. This is not obligatory but it will make your code cleaner. E.g.:+Finally, you can search for ''def-desig-package'' in all your ''package.lisp'' files and get rid of ''def-desig-package'' and ''designator-properties'' there. This is not obligatory but it will make your code cleaner. E.g.:
 <code lisp> <code lisp>
 (desig-props:def-desig-package :cram-designators (desig-props:def-desig-package :cram-designators
Line 50: Line 59:
 <code lisp> <code lisp>
 (with-designators (with-designators
-   ((open-loc ('location `((:to :open) (:to :reach)+   ((open-loc (:location `((:to :open) (:to :reach)
                            (:obj ,?obj)))) ; <- 4 brackets in the end                            (:obj ,?obj)))) ; <- 4 brackets in the end
-    (open-action ('action `((:type :trajectory)+    (open-action (:action `((:type :trajectory)
                             (:to :open) (:obj ,?obj)                             (:to :open) (:obj ,?obj)
                             (:angle ,?angle)))))                             (:angle ,?angle)))))
Line 59: Line 68:
 <code lisp> <code lisp>
 (with-designators (with-designators
-   ((open-loc 'location `((:to :open) (:to :reach)+   ((open-loc :location `((:to :open) (:to :reach)
                           (:obj ,?obj))) ; <- 3 brackets in the end                           (:obj ,?obj))) ; <- 3 brackets in the end
-    (open-action 'action `((:type :trajectory)+    (open-action :action `((:type :trajectory)
                            (:to :open) (:obj ,?obj)                            (:to :open) (:obj ,?obj)
                            (:angle ,?angle))))                            (:angle ,?angle))))
Line 69: Line 78:
 <code lisp> <code lisp>
 (with-designators (with-designators
-  ((some-location 'location '((:some :where)))))+  ((some-location :location '((:some :where)))))
 </code> </code>
 <code lisp> <code lisp>
-   (make-designator 'location '((:some :where)))+   (make-designator :location '((:some :where)))
 </code> </code>
 If you don't like this change, please complain. If you don't like this change, please complain.